fix(browser): add MCP timeout guard to prevent fs hangs by marcelsafin · Pull Request #233 · HKUDS/CLI-Anything

marcelsafin · 2026-04-19T18:46:58Z

Description

Add timeout guards around browser MCP initialize/tool calls to prevent indefinite hangs for commands like cli-anything-browser --json fs ls when backend calls stall.

Fixes #217

Type of Change

New Software CLI (in-repo) — adds a CLI harness inside this monorepo
New Software CLI (standalone repo) — registry-only PR pointing to an external repo
New Feature — adds new functionality to an existing harness or the plugin
Bug Fix — fixes incorrect behavior
Documentation — updates docs only
Other — please describe:

For New Software CLIs (in-repo)

<SOFTWARE>.md SOP document exists at <software>/agent-harness/<SOFTWARE>.md
Canonical SKILL.md exists at skills/cli-anything-<software>/SKILL.md
Packaged compatibility SKILL.md exists at cli_anything/<software>/skills/SKILL.md
Unit tests at cli_anything/<software>/tests/test_core.py are present and pass without backend
E2E tests at cli_anything/<software>/tests/test_full_e2e.py are present
README.md includes the new software (with link to harness directory)
registry.json includes an entry with source_url: null (see Contributing guide)
repl_skin.py in utils/ is an unmodified copy from the plugin

For New Software CLIs (standalone repo)

CLI is installable via pip install <package-name> or a pip install git+https://... URL
SKILL.md exists in the external repo
External repo has its own test suite
registry.json entry includes source_url pointing to the external repo
registry.json entry includes skill_md with full URL to the external SKILL.md
install_cmd in registry.json works (tested locally)

For Existing CLI Modifications

All unit tests pass: python3 -m pytest cli_anything/<software>/tests/test_core.py -v
All E2E tests pass: python3 -m pytest cli_anything/<software>/tests/test_full_e2e.py -v (suite executes; skipped without external DOMShell env)
No test regressions — no previously passing tests were removed or weakened
registry.json entry is updated if version, description, or requirements changed

General Checklist

Code follows existing patterns and conventions
--json flag is supported on any new commands
Commit messages follow the conventional format (feat:, fix:, docs:, test:)
I have tested my changes locally

Test Results

$ /tmp/CLI-Anything/.venv/bin/python -m pytest browser/agent-harness/cli_anything/browser/tests/test_core.py -v
36 passed

$ /tmp/CLI-Anything/.venv/bin/python -m pytest browser/agent-harness/cli_anything/browser/tests/test_security.py -v
49 passed

$ /tmp/CLI-Anything/.venv/bin/python -m pytest browser/agent-harness/cli_anything/browser/tests/test_full_e2e.py -v
10 skipped

marcelsafin · 2026-04-19T19:06:50Z

@maintainers Could you switch requested reviewer to Codex for this PR? Copilot review is currently unavailable on our side.

marcelsafin

Codex review pass completed.

Result: No blocking issues found in this PR.

Checked:

Timeout guard is applied to init + tool calls in daemon and non-daemon paths
Error messaging is actionable for token/server reachability problems
New tests cover default/invalid/min timeout parsing and timeout exception path
Registry version bump aligns with behavior and docs changes

Residual risk: low (mainly environment-dependent DOMShell runtime behavior).

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

marcelsafin · 2026-04-19T19:29:37Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a5c940da61

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

marcelsafin · 2026-04-19T19:36:39Z

@codex address that feedback. Please ensure daemon timeout RuntimeError is propagated and does not trigger automatic non-daemon retry/reissue.

chatgpt-codex-connector · 2026-04-19T19:36:45Z

To use Codex here, create an environment for this repo.

marcelsafin · 2026-04-19T19:40:01Z

Addressed the previous Codex feedback in the latest commit. @codex review

chatgpt-codex-connector · 2026-04-19T19:40:05Z

To use Codex here, create an environment for this repo.

marcelsafin · 2026-04-19T19:59:07Z

@codex review

marcelsafin · 2026-04-19T20:01:44Z

@codex review latest head (3bcd80c) only. Previous P2 timeout-retry feedback has been addressed and thread resolved.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3bcd80c7e9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

marcelsafin · 2026-04-19T20:08:14Z

@codex review

marcelsafin · 2026-04-19T20:10:44Z

@codex review latest head cd55247 for timeout/fallback regression only.

marcelsafin · 2026-04-19T20:11:57Z

@maintainers Status update: latest Codex P1 feedback is addressed in cd55247 and thread is resolved. Verification rerun:

pytest browser/agent-harness/cli_anything/browser/tests/test_core.py -q → 38 passed
pytest browser/agent-harness/cli_anything/browser/tests/test_security.py -q → 49 passed
Could you please take final maintainer review/approval and run required gates?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cd55247595

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

marcelsafin · 2026-04-19T20:14:54Z

@codex review latest head 5338d01 (timeout recovery behavior).

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5338d01d82

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a767396fd0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a2460fd8cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

marcelsafin · 2026-07-11T15:22:04Z

@codex review

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d91bd26808

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

marcelsafin · 2026-07-11T15:50:47Z

@copilot review
@codex review

chatgpt-codex-connector · 2026-07-11T15:51:01Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

marcelsafin · 2026-07-11T16:08:42Z

@copilot review
@codex review

chatgpt-codex-connector · 2026-07-11T16:08:52Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

marcelsafin · 2026-07-11T16:25:19Z

@copilot review
@codex review

chatgpt-codex-connector · 2026-07-11T16:25:26Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

fix(browser): add MCP timeout guard to prevent fs hangs

a5c940d

Copilot AI review requested due to automatic review settings April 19, 2026 18:46

Copilot started reviewing on behalf of marcelsafin April 19, 2026 18:47 View session

marcelsafin commented Apr 19, 2026

View reviewed changes

Copilot AI reviewed Apr 19, 2026

chatgpt-codex-connector Bot reviewed Apr 19, 2026

View reviewed changes

Comment thread browser/agent-harness/cli_anything/browser/utils/domshell_backend.py Outdated

fix(browser): avoid retrying daemon timeouts

3bcd80c

chatgpt-codex-connector Bot reviewed Apr 19, 2026

View reviewed changes

Comment thread browser/agent-harness/cli_anything/browser/utils/domshell_backend.py Outdated

fix(browser): restrict daemon no-retry to timeout errors

cd55247

Copilot AI review requested due to automatic review settings April 19, 2026 20:08

Copilot started reviewing on behalf of marcelsafin April 19, 2026 20:08 View session

chatgpt-codex-connector Bot reviewed Apr 19, 2026

View reviewed changes

Comment thread browser/agent-harness/cli_anything/browser/utils/domshell_backend.py

fix(browser): reset daemon on timeout without retrying tool

5338d01

chatgpt-codex-connector Bot reviewed Apr 19, 2026

View reviewed changes

Comment thread browser/agent-harness/cli_anything/browser/utils/domshell_backend.py

Copilot AI reviewed Apr 19, 2026

marcelsafin requested a review from Copilot April 20, 2026 21:08

Copilot started reviewing on behalf of marcelsafin April 20, 2026 21:08 View session

Copilot AI reviewed Apr 20, 2026

View reviewed changes

Comment thread browser/agent-harness/cli_anything/browser/utils/domshell_backend.py Outdated

Comment thread browser/agent-harness/cli_anything/browser/utils/domshell_backend.py Outdated

chatgpt-codex-connector Bot reviewed Jul 11, 2026

View reviewed changes

Comment thread browser/agent-harness/cli_anything/browser/utils/domshell_backend.py Outdated

Comment thread browser/agent-harness/cli_anything/browser/utils/domshell_backend.py

fix(browser): bound cleanup and restore after anchor timeouts

a2460fd

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 11, 2026 14:50

Copilot started reviewing on behalf of marcelsafin July 11, 2026 14:50 View session

Copilot AI reviewed Jul 11, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jul 11, 2026

View reviewed changes

Comment thread browser/agent-harness/cli_anything/browser/utils/domshell_backend.py

fix(browser): restore cwd after cd timeout

d91bd26

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 11, 2026 15:21

Copilot started reviewing on behalf of marcelsafin July 11, 2026 15:22 View session

Copilot AI reviewed Jul 11, 2026

View reviewed changes

Comment thread browser/agent-harness/cli_anything/browser/utils/domshell_backend.py

chatgpt-codex-connector Bot reviewed Jul 11, 2026

View reviewed changes

Comment thread browser/agent-harness/cli_anything/browser/utils/domshell_backend.py Outdated

fix(browser): close MCP contexts in entering task

c3c21eb

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 11, 2026 15:50

Copilot started reviewing on behalf of marcelsafin July 11, 2026 15:50 View session

Copilot AI reviewed Jul 11, 2026

View reviewed changes

fix: harden DOMShell MCP context lifecycle

4774253

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 11, 2026 16:07

Copilot started reviewing on behalf of marcelsafin July 11, 2026 16:07 View session

Copilot AI reviewed Jul 11, 2026

View reviewed changes

Comment thread browser/agent-harness/cli_anything/browser/utils/domshell_backend.py

fix: keep MCP timeout awaits in task

9495a76

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 11, 2026 16:25

Copilot started reviewing on behalf of marcelsafin July 11, 2026 16:25 View session

Copilot AI reviewed Jul 11, 2026

View reviewed changes

Uh oh!

Conversation

marcelsafin commented Apr 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

For New Software CLIs (in-repo)

For New Software CLIs (standalone repo)

For Existing CLI Modifications

General Checklist

Test Results

Uh oh!

marcelsafin commented Apr 19, 2026

Uh oh!

marcelsafin left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

marcelsafin commented Apr 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

marcelsafin commented Apr 19, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 19, 2026

Uh oh!

marcelsafin commented Apr 19, 2026

Uh oh!

chatgpt-codex-connector Bot commented Apr 19, 2026

Uh oh!

marcelsafin commented Apr 19, 2026

Uh oh!

marcelsafin commented Apr 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

marcelsafin commented Apr 19, 2026

Uh oh!

marcelsafin commented Apr 19, 2026

Uh oh!

marcelsafin commented Apr 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

marcelsafin commented Apr 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

marcelsafin commented Apr 19, 2026 •

edited

Loading